[PATCH] D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size

[Yashaswini Hegde via Phabricator via llvm-commits]

yhegde added a comment.

In D91879#2425553 <https://reviews.llvm.org/D91879#2425553>, @kiranchandramohan wrote:

>> Yes was referring to the 2), second one actually. So probably what check introduced in this patch is applicable as a semantic check. And I suppose the one which you were suggesting can be done at runtime. Also kindly suggest how I can go ahead with this patch.
>
> I was saying that the check that you have introduced in this patch is a direction to the OpenMP runtime on how to assign iterations to threads. Having different chunk sizes on different loops in a parallel region is OK, it is just that the iteration to threads mapping will be different.
>
> My recommendation is to drop this check unless you have a strong reason to not to.

ok. Thank you. Shall I close this review ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91879/new/

https://reviews.llvm.org/D91879