[PATCH] D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 06:38:48 PST 2020


kiranchandramohan added a comment.

> Yes was referring to the 2), second one actually. So probably what check introduced in this patch is applicable as a semantic check. And I suppose the one which you were suggesting can be done at runtime. Also kindly suggest how I can go ahead with this patch.

I was saying that the check that you have introduced in this patch is a direction to the OpenMP runtime on how to assign iterations to threads. Having different chunk sizes on different loops in a parallel region is OK, it is just that the iteration to threads mapping will be different.

My recommendation is to drop this check unless you have a strong reason to not to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91879/new/

https://reviews.llvm.org/D91879



More information about the llvm-commits mailing list