[PATCH] D92258: [ELF][test] Add some tests for versioned symbols in object files

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/symver.s:95
+## The reference from ref.o is redirected. The reference from ref1.o is not.
+# RUN: ld.lld -shared --soname=t --version-script=%t/ver --wrap=foo %t/ref.o %t/ref1.o %t/def1.o %t/wrap.o -o %t.w1
+# RUN: llvm-readobj -r %t.w1 | FileCheck %s --check-prefix=W1REL
----------------
jhenderson wrote:
> Nit: it looks weird that `-shared` has only one dash, when all other options have two. Probably should standardise on one or the other?
> 
> Same applies elsewhere.
The idea is that `-shared` is the most common form (the compiler driver option is `-shared`) so I use it. For `-pie`, I prefer the form as well. For many other long options, I use two dashes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92258/new/

https://reviews.llvm.org/D92258