[PATCH] D92258: [ELF][test] Add some tests for versioned symbols in object files

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 00:43:58 PST 2020


jhenderson added a comment.

As noted elsewhere, my symbol versioning knowledge is lacking. I'm happy with what I've seen, but I could easily have missed things that don't make sense, so best to get someone else to sign off.



================
Comment at: lld/test/ELF/symver.s:95
+## The reference from ref.o is redirected. The reference from ref1.o is not.
+# RUN: ld.lld -shared --soname=t --version-script=%t/ver --wrap=foo %t/ref.o %t/ref1.o %t/def1.o %t/wrap.o -o %t.w1
+# RUN: llvm-readobj -r %t.w1 | FileCheck %s --check-prefix=W1REL
----------------
Nit: it looks weird that `-shared` has only one dash, when all other options have two. Probably should standardise on one or the other?

Same applies elsewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92258/new/

https://reviews.llvm.org/D92258



More information about the llvm-commits mailing list