[PATCH] D87199: [lld-macho] Implement support for PIC

[Jez Ng via Phabricator via llvm-commits]

int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:664
+  config->isPic = config->outputType == MH_DYLIB ||
+                  (config->outputType == MH_EXECUTE && args.hasArg(OPT_pie));
+
----------------
thakis wrote:
> This didn't remove HelpHidden from pie, so we still warn that this is unimplemented.
> 
> Also, this should be on by default when targeting macOS 10.7+.
Thanks! Addressed in D92362.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87199/new/

https://reviews.llvm.org/D87199