[PATCH] D87199: [lld-macho] Implement support for PIC

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 13:19:02 PST 2020


thakis added inline comments.


================
Comment at: lld/MachO/Driver.cpp:664
+  config->isPic = config->outputType == MH_DYLIB ||
+                  (config->outputType == MH_EXECUTE && args.hasArg(OPT_pie));
+
----------------
This didn't remove HelpHidden from pie, so we still warn that this is unimplemented.

Also, this should be on by default when targeting macOS 10.7+.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87199/new/

https://reviews.llvm.org/D87199



More information about the llvm-commits mailing list