[PATCH] D91092: [SVE][CodeGen] Lower scalable masked gathers

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

Thanks for splitting this work up into smaller patches. This patch in the series looks good to me now!



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:116
 
+static cl::opt<bool>
+EnableCombineMGatherIntrinsics("aarch64-enable-mgather-combine", cl::Hidden,
----------------
nit: can you add a comment here to describe that this option is temporary and only exists for the purpose of testing functionality added to DAGCombiner.cpp. Perhaps you can also say there is the expectation to remove it in the future, when both implementations of will be based off MGATHER. rather than relying on the ISD nodes we added for the `llvm.aarch64.sve.ld1.gather` intrinsics.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91092/new/

https://reviews.llvm.org/D91092