[PATCH] D92261: [dfsan] Track field/index-level shadow values in variables

[stephan.yichao.zhao via Phabricator via llvm-commits]

stephan.yichao.zhao created this revision.
stephan.yichao.zhao added reviewers: pcc, morehouse.
Herald added subscribers: llvm-commits, Sanitizers, arphaman, hiraditya.
Herald added projects: Sanitizers, LLVM.
stephan.yichao.zhao requested review of this revision.

*************

- The problem *************

See motivation examples in compiler-rt/test/dfsan/pair.cpp. The current
DFSan always uses a 16bit shadow value for a variable with any type by
combining all shadow values of all bytes of the variable. So it cannot
distinguish two fields of a struct: each field's shadow value equals the
combined shadow value of all fields. This introduces an overtaint issue.

Consider a parsing function

  std::pair<char*, int> get_token(char* p);

where p points to a buffer to parse, the returned pair includes the next
token and the pointer to the position in the buffer after the token.

If the token is tainted, then both the returned pointer and int ar
tainted. If the parser keeps on using get_token for the rest parsing,
all the following outputs are tainted because of the tainted pointer.

The CL is the first change to address the issue.

**************************

- The proposed improvement **************************

Eventually all fields and indices have their own shadow values in
variables and memory.

For example, variables with type {i1, i3}, [2 x i1], {[2 x i4], i8},
[2 x {i1, i1}] have shadow values with type {i16, i16}, [2 x i16],
{[2 x i16], i16}, [2 x {i16, i16}] correspondingly; variables with
primary type still have shadow values i16.

***************************

- An potential implementation plan ***************************

The idea is to adopt the change incrementially.

1. This CL Support field-level accuracy at variables/args/ret in TLS mode, load/store/alloca still use combined shadow values.

  After the alloca promotion and SSA construction phases (>=-O1), we assume alloca and memory operations are reduced. So if struct variables do not relate to memory, their tracking is accurate at field level.

2. Support field-level accuracy at alloca
3. Support field-level accuracy at load/store

  These two should make O0 and real memory access work.

4. Support vector if necessary.
5. Support Args mode if necessary.
6. Support passing more accurate shadow values via custom functions if necessary.

***************

- About this CL. ***************

The CL did the following

1. extended TLS arg/ret to work with aggregate types. This is similar to what MSan does.
2. implemented how to map between an original type/value/zero-const to its shadow type/value/zero-const.
3. extended (insert|extract)value to use field/index-level progagation.
4. for other instructions, propagation rules are combining inputs by or. The CL converts between aggragate and primary shadow values at the cases.
5. Custom function interfaces also need such a conversion because all existing custom functions use i16. It is unclear whether custom functions need more accurate shadow propagation yet.
6. Added test cases for aggregate type related cases.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92261

Files:
  compiler-rt/lib/dfsan/dfsan.cpp
  compiler-rt/test/dfsan/pair.cpp
  compiler-rt/test/dfsan/struct.c
  llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
  llvm/test/Instrumentation/DataFlowSanitizer/abilist_aggregate.ll
  llvm/test/Instrumentation/DataFlowSanitizer/arith.ll
  llvm/test/Instrumentation/DataFlowSanitizer/array.ll
  llvm/test/Instrumentation/DataFlowSanitizer/call.ll
  llvm/test/Instrumentation/DataFlowSanitizer/callback.ll
  llvm/test/Instrumentation/DataFlowSanitizer/fast16labels.ll
  llvm/test/Instrumentation/DataFlowSanitizer/load.ll
  llvm/test/Instrumentation/DataFlowSanitizer/phi.ll
  llvm/test/Instrumentation/DataFlowSanitizer/select.ll
  llvm/test/Instrumentation/DataFlowSanitizer/struct.ll
  llvm/test/Instrumentation/DataFlowSanitizer/union-large.ll
  llvm/test/Instrumentation/DataFlowSanitizer/vector.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92261.308142.patch
Type: text/x-patch
Size: 119330 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201128/14e11864/attachment.bin>