[PATCH] D92219: [AMDGPU][GlobalISel] Avoid selecting S_PACK with constants

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 27 06:01:21 PST 2020

foad added inline comments.

Comment at: llvm/include/llvm/CodeGen/GlobalISel/Utils.h:146
+                                  bool HandleFConstants = true,
+                                  bool AnyExtAsZext = false);
 const ConstantFP* getConstantFPVRegVal(Register VReg,
mbrkusanin wrote:
> foad wrote:
> > I'm not sure if we need a flag for this. Could we do it unconditionally? @qcolombet ?
> There were no regressions for check-all when I tried it that way, but I wasn't sure if I should leave it like that.
I think it's probably safe to treat anyext the same as zext in this function, but maybe wait for comments from other globalisel maintainers (who may be on thanksgiving vacation).



More information about the llvm-commits mailing list