[PATCH] D92219: [AMDGPU][GlobalISel] Avoid selecting S_PACK with constants

Mirko Brkusanin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 27 05:58:28 PST 2020


mbrkusanin added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/Utils.h:146
+                                  bool HandleFConstants = true,
+                                  bool AnyExtAsZext = false);
 const ConstantFP* getConstantFPVRegVal(Register VReg,
----------------
foad wrote:
> I'm not sure if we need a flag for this. Could we do it unconditionally? @qcolombet ?
There were no regressions for check-all when I tried it that way, but I wasn't sure if I should leave it like that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92219/new/

https://reviews.llvm.org/D92219



More information about the llvm-commits mailing list