[PATCH] D91924: [X86] Have indirect calls take 64-bit operands in 64-bit modes

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

Thanks for the clarification - LGTM with a couple of minors



================
Comment at: llvm/lib/Target/X86/X86FastISel.cpp:1086
+    auto GetCallRegForValue = [this](const Value *V) {
+      auto Reg = getRegForValue(V);
+
----------------
(style) Avoid auto - just use Register.


================
Comment at: llvm/lib/Target/X86/X86FastISel.cpp:1090
+      if (Reg && Subtarget->isTarget64BitILP32()) {
+        auto CopyReg = createResultReg(&X86::GR32RegClass);
+        BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, DbgLoc, TII.get(X86::MOV32rr),
----------------
(style) Avoid auto - just use Register.


================
Comment at: llvm/lib/Target/X86/X86FastISel.cpp:1095
+
+        auto ExtReg = createResultReg(&X86::GR64RegClass);
+        BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, DbgLoc,
----------------
(style) Avoid auto - just use Register.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91924/new/

https://reviews.llvm.org/D91924