[PATCH] D91924: [X86] Have indirect calls take 64-bit operands in 64-bit modes

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 26 14:58:21 PST 2020

hvdijk added a comment.

In D91924#2418221 <https://reviews.llvm.org/D91924#2418221>, @RKSimon wrote:

> We already have fast-isel-call tests - could we add gnux32 test coverage there?

I took a look, and none of them would be affected by this change (none of them use PIC or indirect calls). It does seem like it might be a useful separate improvement, but it's a bit tricky: `fast-isel-call.ll` tests x86-specific calling conventions so probably wouldn't work, `fast-isel-call-bool.ll` and `fast-isel-call-cleanup.ll` look like they test for specific bugs that may or may not be/have been a problem for x32.

(For completeness, I mentioned it already but not in the description of this diff: this change is covered by a test, this fixes a problem exposed by `pic.ll`.)

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list