[PATCH] D91595: [Debugify] Support checking Machine IR debug info
Xiang Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 26 15:58:16 PST 2020
xiangzhangllvm added inline comments.
================
Comment at: llvm/lib/CodeGen/MachineCheckDebugify.cpp:76
+ for (MachineInstr &MI : MBB) {
+ if (!MI.isDebugValue())
+ continue;
----------------
djtodoro wrote:
> Please add a TODO marker for `DBG_INSTR_REF` as well (it is still under an experimental option, but we should be aware it is coming).
OK, I'll mark it when I commit it (next week).
For DBG_INSTR_REF it is a good idea to split the value and location for llvm.dbg.value.
Thanks for all your works !!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91595/new/
https://reviews.llvm.org/D91595
More information about the llvm-commits
mailing list