[PATCH] D91595: [Debugify] Support checking Machine IR debug info

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 26 06:46:23 PST 2020


djtodoro accepted this revision.
djtodoro added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

(please leave some time (a few days) to other reviewers to take a look)



================
Comment at: llvm/lib/CodeGen/MachineCheckDebugify.cpp:76
+        for (MachineInstr &MI : MBB) {
+          if (!MI.isDebugValue())
+            continue;
----------------
Please add a TODO marker for `DBG_INSTR_REF` as well (it is still under an experimental option, but we should be aware it is coming).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91595/new/

https://reviews.llvm.org/D91595



More information about the llvm-commits mailing list