[PATCH] D91733: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available

Adhemerval Zanella via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 26 03:29:05 PST 2020


zatrazz added a comment.

In D91733#2407055 <https://reviews.llvm.org/D91733#2407055>, @wolfgangp wrote:

> Isn't COMPILER_RT_HAS_FLOAT16 generated using the host compiler? If so, using the same flag for a compiler_rt test could fail if the host compiler supports f16 and the target compiler does not.

Indeed and it seems to be for mac. I will work on a fix, sorry for take to long to notice the issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91733/new/

https://reviews.llvm.org/D91733



More information about the llvm-commits mailing list