[PATCH] D92158: Also include component groups in llvm-config --components list

[serge via Phabricator via llvm-commits]

serge-sans-paille added a comment.

We already discussed this change on IRC, I'm fine with it, once the suggested renaming is done.



================
Comment at: llvm/cmake/modules/LLVM-Build.cmake:14
   list(APPEND llvmbuild_components all)
-  list(APPEND llvmbuild_components all-targets)
-  list(APPEND llvmbuild_components Engine)
-  list(APPEND llvmbuild_components Native)
-  list(APPEND llvmbuild_components NativeCodeGen)
-  foreach(llvm_target_to_build ${LLVM_TARGETS_TO_BUILD})
+  foreach(llvm_target_to_build all-targets Engine Native NativeCodeGen ${LLVM_TARGETS_TO_BUILD})
     list(APPEND llvmbuild_components ${llvm_target_to_build})
----------------
`llvm_target_to_build` is probably no longer a valid name here, probably just use `llvm_component`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92158/new/

https://reviews.llvm.org/D92158