[PATCH] D92158: Also include component groups in llvm-config --components list

Mariusz Ceier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 26 00:47:08 PST 2020

mceier created this revision.
mceier added a reviewer: serge-sans-paille.
Herald added subscribers: llvm-commits, lxfind, modocache, tpr, mgorny.
Herald added a project: LLVM.
mceier requested review of this revision.

Without this change mesa fails while looking for llvm components like amdgpu, engine or native:

  Run-time dependency LLVM (modules: amdgpu(missing), bitreader, bitwriter, core, engine(missing), executionengine, instcombine, ipo, mcdisassembler, mcjit, native(missing), scalaropts, transformutils, coroutines)
  Looking for a fallback subproject for the dependency llvm (modules: bitwriter, engine, mcdisassembler, mcjit, core, executionengine, scalaropts, transformutils, instcombine, amdgpu, native, bitreader, ipo)  

This change adds component groups (like all-targets, engine, native, amdgpu) to the "all" component.

  rG LLVM Github Monorepo



Index: llvm/cmake/modules/LLVM-Build.cmake
--- llvm/cmake/modules/LLVM-Build.cmake
+++ llvm/cmake/modules/LLVM-Build.cmake
@@ -11,12 +11,9 @@
     list(APPEND all_component_libdeps ${component_name})
   list(APPEND llvmbuild_components all)
-  list(APPEND llvmbuild_components all-targets)
-  list(APPEND llvmbuild_components Engine)
-  list(APPEND llvmbuild_components Native)
-  list(APPEND llvmbuild_components NativeCodeGen)
-  foreach(llvm_target_to_build ${LLVM_TARGETS_TO_BUILD})
+  foreach(llvm_target_to_build all-targets Engine Native NativeCodeGen ${LLVM_TARGETS_TO_BUILD})
     list(APPEND llvmbuild_components ${llvm_target_to_build})
+    list(APPEND all_component_libdeps ${llvm_target_to_build})
   list(LENGTH llvmbuild_components llvmbuild_components_size)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92158.307775.patch
Type: text/x-patch
Size: 877 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201126/a8a0eed9/attachment.bin>

More information about the llvm-commits mailing list