[PATCH] D91595: [Debugify] Support checking Machine IR debug info

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 25 21:30:12 PST 2020

xiangzhangllvm added inline comments.

Comment at: llvm/lib/CodeGen/MachineCheckDebugify.cpp:52-55
+      MachineFunction *MaybeMF = MMI.getMachineFunction(F);
+      if (!MaybeMF)
+        continue;
+      MachineFunction &MF = *MaybeMF;
djtodoro wrote:
> We don't need `MaybeMF`,
>   MachineFunction *MF = MMI.getMachineFunction(F);
>   if (!MF)
>     continue;
> and use `*MF`.
Yes, I'll refine here, thank you again : )

Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:126
+    cl::desc(
+        "Debugify MIR before and Check + Strip debug after "
+        "each pass except those known to be unsafe when debug info is present"),
djtodoro wrote:
> The description should be more precise.
The name and description of "debugify-and-check-strip-all-safe" refer to upper "debugify-and-strip-all-safe", Maybe It is a little different for our non-English speaking people to name or descript well. Do you have good suggestion of its name ?
How about I refine the description to "Debugify MIR before each pass except those known to be unsafe when debug info is present, then run mir-check-debugify for them, and finally strip the debug info with mir-strip-debug" ?



More information about the llvm-commits mailing list