[PATCH] D91595: [Debugify] Support checking Machine IR debug info

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

Thanks for addressing the comments! We are almost there.



================
Comment at: llvm/docs/HowToUpdateDebugInfo.rst:412
+
+  $ llc -debugify-and-check-strip-all-safe -run-pass=... <other llc args>
+  $ llc -debugify-and-check-strip-all-safe -O1 <other llc args>
----------------
The name of option `-debugify-and-check-strip-all-safe` seems a bit confusing ...


================
Comment at: llvm/lib/CodeGen/MachineCheckDebugify.cpp:52-55
+      MachineFunction *MaybeMF = MMI.getMachineFunction(F);
+      if (!MaybeMF)
+        continue;
+      MachineFunction &MF = *MaybeMF;
----------------
We don't need `MaybeMF`,

  MachineFunction *MF = MMI.getMachineFunction(F);
  if (!MF)
    continue;
 
and use `*MF`.


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:126
+    cl::desc(
+        "Debugify MIR before and Check + Strip debug after "
+        "each pass except those known to be unsafe when debug info is present"),
----------------
The description should be more precise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91595/new/

https://reviews.llvm.org/D91595