[PATCH] D91834: [SelectionDAG] Use TypeSize for the stack offset.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 24 19:10:29 PST 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1423
+  TypeSize TypeByteSize = MemVT.getStoreSize();
   assert(TypeByteSize > 0 && "Vector element type too small for stack store!");
 
----------------
Does this assert need to be updated so that it doesn't implicitly cast TypeByteSize to an unsigned? I assume that will print a warning about assuming fixed size.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91834/new/

https://reviews.llvm.org/D91834



More information about the llvm-commits mailing list