[PATCH] D90488: [flang][openacc] Lower init and shutdown directive

Tue Nov 24 13:53:11 PST 2020

clementval added a comment.

In D90488#2414789 <https://reviews.llvm.org/D90488#2414789>, @mehdi_amini wrote:

> In D90488#2414751 <https://reviews.llvm.org/D90488#2414751>, @clementval wrote:
>
>> In D90488#2414718 <https://reviews.llvm.org/D90488#2414718>, @mehdi_amini wrote:
>>
>>> Do you have tests for this?
>>
>> Test still live in the fir-dev branch. Since not all the infra is present for the test to be executed, there were not upstreamed yet. the rest of the fir-dev branch should be upstream very soon but I can hardly influence that.
>
> I'd like to see IR -> IR unit-test (`mlir-opt` style) provided here. I don't think it is reasonable to upstream code without proper testing.

There are IR to IR test for those operations in mlir itself where the dialect is located.

All OpenMP and OpenACC lowering are waiting on the fir-dev to be upstream.

So should we un-upstream the code for the time being?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90488/new/

https://reviews.llvm.org/D90488