[PATCH] D90488: [flang][openacc] Lower init and shutdown directive

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 24 13:16:57 PST 2020


mehdi_amini added a comment.

In D90488#2414751 <https://reviews.llvm.org/D90488#2414751>, @clementval wrote:

> In D90488#2414718 <https://reviews.llvm.org/D90488#2414718>, @mehdi_amini wrote:
>
>> Do you have tests for this?
>
> Test still live in the fir-dev branch. Since not all the infra is present for the test to be executed, there were not upstreamed yet. the rest of the fir-dev branch should be upstream very soon but I can hardly influence that.

I'd like to see IR -> IR unit-test (`mlir-opt` style) provided here. I don't think it is reasonable to upstream code without proper testing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90488/new/

https://reviews.llvm.org/D90488



More information about the llvm-commits mailing list