[PATCH] D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format

[Yusra Syeda via Phabricator via llvm-commits]

yusra.syeda marked 4 inline comments as done.
yusra.syeda added inline comments.


================
Comment at: llvm/include/llvm/Object/GOFF.h:137
+    setArchitectureLevel(1);
+  }
+
----------------
kpn wrote:
> Missing module properties field. 
This field will be added in a future patch.


================
Comment at: llvm/include/llvm/Object/GOFF.h:156
+
+  void setDataLength(uint16_t Length) { set<uint16_t>(22, Length); }
+
----------------
kpn wrote:
> I don't see any support for "Text Encoding". These fields are at bytes 16-21. Maybe a comment if you don't plan on ever implementing it?
This will also be added in a future patch.


================
Comment at: llvm/include/llvm/Object/GOFF.h:266
+
+  void setIndirectReference(bool Indirect) {
+    uint8_t Value = Indirect ? 1 : 0;
----------------
kpn wrote:
> No COMMON flag?
Same with this field.


================
Comment at: llvm/include/llvm/Object/GOFF.h:487
+    set<uint32_t>(Offset + 16, Ent.POffset);
+  }
+
----------------
kpn wrote:
> I assume RLD continuation records and relocation compression are coming later.
Yes, these will be coming in a future patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89071/new/

https://reviews.llvm.org/D89071