[PATCH] D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format

Yusra Syeda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 15:13:33 PST 2020

yusra.syeda marked an inline comment as done.
yusra.syeda added inline comments.

Comment at: llvm/include/llvm/Object/GOFF.h:223
+  // This intentionally uses the same field as above.
+  void setERSymbolType(GOFF::ESDERSymbolType Type) { setBits(41, 5, 3, Type); }
kpn wrote:
> Is this right? Bit 41.3 in "Program Management" is the "Removable Class Flag", which matches the code above this. Bit 41.4-6 are marked reserved, and bit 41.7 is unnamed but if set means "Reserve 16 bytes at beginning of class. MRG class ED records only." 
> So it looks like the code is writing to the wrong part of byte 41. The code that reads from that byte also appears incorrect. Shouldn't it be (41, 4, 3)?
The setERSymbolType and getERSymbolType functions have been removed from this patch as they are not required. 

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list