[PATCH] D92018: [llvm-readelf/obj] - Deduplicate the logic that prints notes. NFCI.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 24 05:49:13 PST 2020
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
Looks okay. I'm not a massive fan of having three lambdas though, and I wonder whether they'd be better off as virtual functions, at least to some extent, of the dump style classes (probably only for the `ProcessNote` one though, I accept).
CHANGES SINCE LAST ACTION
More information about the llvm-commits