[PATCH] D92018: [llvm-readelf/obj] - Deduplicate the logic that prints notes. NFCI.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6847
 
-  auto PrintHeader = [&](Optional<StringRef> SecName,
-                         const typename ELFT::Off Offset,
-                         const typename ELFT::Addr Size) {
+  std::unique_ptr<DictScope> NoteScope;
+  auto StartNotes = [&](Optional<StringRef> SecName,
----------------
jhenderson wrote:
> I might be missing something, but I don't see this scoping in the old behaviour? Without it, we also wouldn't need the `EndNotes` heper.
Never mind... spotted it. Will look a bit more.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92018/new/

https://reviews.llvm.org/D92018