[PATCH] D91803: [lld] Use -1 as tombstone value for discarded code ranges

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 07:49:10 PST 2020


sbc100 added a comment.

There are 4 callers of calcNewValue():

InputChunk::writeTo
InputFunction::calculateSize
InputFunction::writeTo
InputSegment::generateRelocationCode

It seems that they should all be consistent in passing getTombstone() as the second argument.  It doesn't make sense that different callsites would get a different new value for a given relocation.   They all logically want to get the same answer I believe.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91803/new/

https://reviews.llvm.org/D91803



More information about the llvm-commits mailing list