[PATCH] D91803: [lld] Use -1 as tombstone value for discarded code ranges
Eric Leese via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 23 07:26:54 PST 2020
Eric added inline comments.
Comment at: lld/test/wasm/debug-removed-fn.ll:7
; CHECK: 0x0000000000000005
-; CHECK: 0x0000000000000000
+; CHECK: 0x00000000ffffffff
> dblaikie wrote:
> > This looks suspcious - is something in the implementation (or the dumper) truncating the 64 bit -1 to a 32 bit -1? Or is this a bug in the dumper that it's printing out a 32bit value as a 64 bit value?
> Looks like this file is coming from a R_WASM_FUNCTION_OFFSET_I32 type relocation so this is being written as 32 bits. I assume the dumper casts to 64 bits whether it read a 32 or 64 bit address.
It turns out if I update my llvm repo to include your tombstone handling code in llvm-dwarfdump, this line disappears.
CHANGES SINCE LAST ACTION
More information about the llvm-commits