[PATCH] D91423: [NFC][DebugInfo] Factor LowerDbgDeclare into two functions [1/3]

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 02:13:36 PST 2020

Orlando added a comment.

Thanks @aprantl for looking at this. I meant to state in the description that this NFC change is set up for D91424 <https://reviews.llvm.org/D91424> to reduce help highlight the functional change there.

Comment at: llvm/lib/Transforms/Utils/Local.cpp:1497
+static bool ConvertIndirectDbgIntrinsicToDbgValues(DbgDeclareInst *DII,
+                                                   DIBuilder &DIB) {
aprantl wrote:
> Doxygen comment here to explain what this function does?
> Which other indirect intrinsics are there?
> I'm not sure if the name indirect captures the intention well unless it's part of a greater plan for the future. Otherwise I would just say DbgDeclare to avoid confusion.
Naming this was a little tricky as in the next patch in this stack (D91424) the function is changed to work on `dbg.value+deref`s too.

Comment at: llvm/lib/Transforms/Utils/Local.cpp:1549
 /// LowerDbgDeclare - Lowers llvm.dbg.declare intrinsics into appropriate set
 /// of llvm.dbg.value intrinsics.
aprantl wrote:
> Nit: remove `LowerDbgDeclare -`
> Also,  the doxygen comment should be in the header file and only there.
I left this as I found it, but I will happily update it.



More information about the llvm-commits mailing list