[PATCH] D90973: [RISCV] Remove RV32 HwMode. Use DefaultMode for RV32

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCV.td:182-183
 
+// RV32 uses DefaultMode.
 def RV64           : HwMode<"+64bit">;
 
----------------
lenary wrote:
> lenary wrote:
> > Is there a way of doing an alias here, so we don't have to document that defaultmode is rv32 everywhere?
> > 
> > Something like the following (I guess it has to be a let, not a def, but I could be wrong).
> > ```
> > let RV32 = DefaultMode;`
> > ```
> Sorry, it can't be a let, but you could do the following, I think
> ```
> defvar RV32 = DefaultMode;
> ```
> 
> And then in an example pulled from below:
> ```
> def XLenVT : ValueTypeByHwMode<[RV64, RV32],
>                                [i64,  i32]>;
> ```
That works, so I'll switch to that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90973/new/

https://reviews.llvm.org/D90973