[PATCH] D90973: [RISCV] Remove RV32 HwMode. Use DefaultMode for RV32

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 20 04:52:03 PST 2020


lenary added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCV.td:182-183
 
+// RV32 uses DefaultMode.
 def RV64           : HwMode<"+64bit">;
 
----------------
lenary wrote:
> Is there a way of doing an alias here, so we don't have to document that defaultmode is rv32 everywhere?
> 
> Something like the following (I guess it has to be a let, not a def, but I could be wrong).
> ```
> let RV32 = DefaultMode;`
> ```
Sorry, it can't be a let, but you could do the following, I think
```
defvar RV32 = DefaultMode;
```

And then in an example pulled from below:
```
def XLenVT : ValueTypeByHwMode<[RV64, RV32],
                               [i64,  i32]>;
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90973/new/

https://reviews.llvm.org/D90973



More information about the llvm-commits mailing list