[PATCH] D89049: [AIX][XCOFF] print out the traceback info

[Digger via Phabricator via llvm-commits]

DiggerLin marked 2 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:454
   bool hasExtensionTable() const;
-  uint8_t getNumofGPRsSaved() const;
+  uint8_t getNumOfGPRsSaved() const;
 
----------------
jhenderson wrote:
> This change is unrelated to this patch, so should be moved to a separate commit.
created NFC patch. https://reviews.llvm.org/D91882


================
Comment at: llvm/tools/llvm-objdump/XCOFFDump.cpp:319-322
+#undef PRINTBOOL
+#undef PRINTGET
+#undef SPLIT
+#undef PRINTOPTIONAL
----------------
jhenderson wrote:
> No need to #undef things at EOF in a cpp surely?
I think we will add more code in the file in future  when we add more functionality. . if  not have undef now, we maybe forgot to add the undef in future when we add more code in future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89049/new/

https://reviews.llvm.org/D89049