[PATCH] D89049: [AIX][XCOFF] print out the traceback info

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I've skimmed some of this, but most of this is XCOFF specific, so other developers are probably better off reviewing it.



================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:454
   bool hasExtensionTable() const;
-  uint8_t getNumofGPRsSaved() const;
+  uint8_t getNumOfGPRsSaved() const;
 
----------------
This change is unrelated to this patch, so should be moved to a separate commit.


================
Comment at: llvm/tools/llvm-objdump/XCOFFDump.cpp:144-146
+    OS << "\tWarning: Parse traceback table failure!(The value in error msg is "
+          "calculated based on traceback begin) \n";
+    OS << "\tError msg: " << toString(TTOrErr.takeError());
----------------
Please report warnings/errors properly, as per what all tools do, rather than print them inline with the disassembly. See also the bit on warning/error guidelines in the coding standards too.


================
Comment at: llvm/tools/llvm-objdump/XCOFFDump.cpp:319-322
+#undef PRINTBOOL
+#undef PRINTGET
+#undef SPLIT
+#undef PRINTOPTIONAL
----------------
No need to #undef things at EOF in a cpp surely?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89049/new/

https://reviews.llvm.org/D89049