[PATCH] D91814: [llvm-symbolizer] Switch to using native symbolizer by default on Windows

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-symbolizer/Opts.td:44
 defm untag_addresses : B<"untag-addresses", "", "Remove memory tags from addresses before symbolization">;
-def use_native_pdb_reader : F<"use-native-pdb-reader", "Use native PDB functionality">;
+def use_dia: F<"dia", "Use DIA for symbolization">;
 def verbose : F<"verbose", "Print verbose line info">;
----------------
amccarth wrote:
> I think this help string might be a smidge more useful to people who don't already know what DIA is.
Could you please also add this option to the llvm-symbolizer Command Guide (llvm/docs/CommadnGuide/llvm-symbolizer.rst)? You might want to add a new subsection to the existing document for Windows/COFF/PDB specific options (like there is already for Mach-O).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91814/new/

https://reviews.llvm.org/D91814