[PATCH] D91814: [llvm-symbolizer] Switch to using native symbolizer by default on Windows

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added a comment.

I added two suggested edits for your consideration.

Other than those, this looks good.

(It seems there's some old Cmake cruft around LLVM_ENABLE_DIA_SDK that could probably be cleaned up in a separate patch.)



================
Comment at: llvm/tools/llvm-symbolizer/Opts.td:44
 defm untag_addresses : B<"untag-addresses", "", "Remove memory tags from addresses before symbolization">;
-def use_native_pdb_reader : F<"use-native-pdb-reader", "Use native PDB functionality">;
+def use_dia: F<"dia", "Use DIA for symbolization">;
 def verbose : F<"verbose", "Print verbose line info">;
----------------
I think this help string might be a smidge more useful to people who don't already know what DIA is.


================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:291
       Args.hasFlag(OPT_untag_addresses, OPT_no_untag_addresses, !IsAddr2Line);
-  Opts.UseNativePDBReader = Args.hasArg(OPT_use_native_pdb_reader);
+  Opts.UseDIA = Args.hasArg(OPT_use_dia);
   Opts.UseSymbolTable = true;
----------------
`--use-native-pdb-reader` was always possible, but `--dia` isn't, so let's let the user know if we cannot satisfy their request.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91814/new/

https://reviews.llvm.org/D91814