[PATCH] D91761: [FileCheck] Add a literal check directive

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar added a comment.

In D91761#2407009 <https://reviews.llvm.org/D91761#2407009>, @probinson wrote:

> I have to say, I'm not super enthused about this feature.  Typically we've added directives when there's no other way to achieve the desired effect

SAME could be achieved without needing SAME, COUNT too, and NEXT could be folded in too by extending to multi-line regex and verifying no newlines so too DAG. So I believe there is a goal with directives to make checks readable for users & simple to interpret rather than just possible. Escaping is possible but obscures what is being tested and easy to get wrong.

> Does this excessive-escaping situation come up very often in practice?

Very often indeed in MLIR as dense constants use [] pairs for values, so if you have a multi-dimensional tensor value you end up with a lot of escaping.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91761/new/

https://reviews.llvm.org/D91761