[PATCH] D91761: [FileCheck] Add a literal check directive
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 19 17:38:52 PST 2020
probinson added a comment.
I have to say, I'm not super enthused about this feature. Typically we've added directives when there's no other way to achieve the desired effect; the LITERAL feature doesn't meet that bar. It's a way to simplify something that you could do already. Not to say I'm going to insist on killing it, but I would like to hear more justification.
Does this excessive-escaping situation come up very often in practice? I saw a relatively simple case recently, `{{{.*}}}` which is, a pair of braces with anything in between. (Which FileCheck doesn't parse in the intuitive way, but it does work as intended.) But that's about the most complicated thing I've come across lately.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91761/new/
https://reviews.llvm.org/D91761
More information about the llvm-commits
mailing list