[PATCH] D91811: Port -lower-matrix-intrinsics-minimal to NPM

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 15:08:19 PST 2020


asbirlea accepted this revision.
asbirlea added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:1347
       return;
 
     auto *LoadOp0 = dyn_cast<LoadInst>(MatMul->getOperand(0));
----------------
Could you add an assert on `AA` and `LI` here? The `DT` check seems to imply `AA` is guaranteed to exist, and we also mark `LI` as preserved on the same premise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91811/new/

https://reviews.llvm.org/D91811



More information about the llvm-commits mailing list