[PATCH] D91811: Port -lower-matrix-intrinsics-minimal to NPM

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:1952
 
-  LowerMatrixIntrinsics LMT(F, TTI, &AA, &DT, &LI, &ORE);
+  LowerMatrixIntrinsics LMT(F, TTI, AA, DT, LI, ORE);
   if (LMT.Visit()) {
----------------
asbirlea wrote:
> I'm missing context here...
> Looking at the code for `LowerMatrixIntrinsics` I don't see checks for the analyses being nullptr. I don't see where visiting is limited when analyses are not retrieved.
> Even if checks existed, the analyses cannot be preserved below if IR changes occur.
> 
I'm following LowerMatrixIntrinsicsMinimalLegacyPass below, the code was changed in https://reviews.llvm.org/D76867.
Modified the PreservedAnalyses.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91811/new/

https://reviews.llvm.org/D91811