[PATCH] D90050: AMDGPU/GlobalISel: Add integer med3 combines

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 08:50:05 PST 2020


arsenm added a comment.

In D90050#2405812 <https://reviews.llvm.org/D90050#2405812>, @foad wrote:

> In D90050#2405810 <https://reviews.llvm.org/D90050#2405810>, @Petar.Avramovic wrote:
>
>> Should we move this combine after register bank select and skip min/max with sgpr bank?
>
> I'm not sure. @arsenm is that the usual way to handle this?

This should probably be done after RegBankSelect, although post-regbankselect combines are a yet unsolved problem. The dummy pass is there for it, it just doesn't do anything yet


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90050/new/

https://reviews.llvm.org/D90050



More information about the llvm-commits mailing list