[PATCH] D72184: [BPF] support atomic instructions

Brendan Jackman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 03:25:21 PST 2020


jackmanb added a comment.

Can we please keep barriers out of scope? I think there's a lot of design to be done there and I'd rather just get the core atomics working first.

BTW I got

  [ 31%] Building LanaiGenDAGISel.inc...                                                                                                       
  Included from /usr/local/google/home/jackmanb/src/llvm-project/llvm/lib/Target/BPF/BPF.td:13:                                                
  /usr/local/google/home/jackmanb/src/llvm-project/llvm/lib/Target/BPF/BPFInstrInfo.td:677:1: error: Pattern doesn't match mayStore = 1        
  def : Pat<(atomic_fence (timm), (timm)), (SYNC)>;                                                                                            
  ^                                                                                                                                            
  error: pattern conflicts                                                                                                                     

But removing line 677 fixes it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72184/new/

https://reviews.llvm.org/D72184



More information about the llvm-commits mailing list