[PATCH] D91670: Fix crash after looking up dwo_id=0 in CU index.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Not looked at the whole thing in depth, but my comments have been addressed, so happy for this to land from my point of view, if others are happy.



================
Comment at: llvm/test/tools/llvm-symbolizer/split-dwarf-zero-signature-not-found.s:48
+        .section        .debug_addr,"", at progbits
+        .quad   A\I
+        .quad   F\I
----------------
jgorbe wrote:
> MaskRay wrote:
> > `A\I` is undefined. Consider defining the symbol to be more realistic.
> Good catch! Went a bit too far trimming the lldb test this is based on :)
It's probably not applicable here, but FYI, yaml2obj now has some DWARF support which allows you to craft sections using YAML rather than assembly, without needing to specify all details. Take a look at some of the tests that are using it for examples of how you might use it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91670/new/

https://reviews.llvm.org/D91670