[PATCH] D91670: Fix crash after looking up dwo_id=0 in CU index.

Jorge Gorbe Moya via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 12:26:32 PST 2020


jgorbe marked 2 inline comments as done.
jgorbe added a comment.

>> then the check `Rows[H].getSignature() != S` won't fail
>
> The condition fails. It should return nullptr but returned a Rows entry.

Yeah, I could have expressed this better in the summary. What I meant with "the check won't fail" was that the check `Rows[H].getSignature() != S` is not enough to cause the lookup to fail and return a nullptr (as it should). I'll fix it in the actual commit message.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91670/new/

https://reviews.llvm.org/D91670



More information about the llvm-commits mailing list