[PATCH] D87326: [ADT] Fix reference invalidation when self referencing a SmallVector
Duncan P. N. Exon Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 18 18:19:58 PST 2020
dexonsmith added reviewers: mehdi_amini, dexonsmith.
dexonsmith added a comment.
FYI, I landed assertions for various reference invalidations in https://reviews.llvm.org/D91744.
I wonder if this patch could be landed incrementally, fixing one API at a time from the bottom up. For example, we might start with just `push_back` or `assign`, hopefully side-stepping any compile-time regression by incorporating the relevant parts of https://reviews.llvm.org/D91467 to skip the slow path for small enough, trivial `T`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87326/new/
https://reviews.llvm.org/D87326
More information about the llvm-commits
mailing list