[PATCH] D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 18 17:45:56 PST 2020
MaskRay added inline comments.
================
Comment at: llvm/lib/Object/GOFFObjectFile.cpp:322
+
+ for (size_t I = 0; I < SectionList.size(); ++I) {
+ bool Found;
----------------
https://llvm.org/docs/CodingStandards.html#don-t-evaluate-end-every-time-through-a-loop
several instances in the file do not obey the rule.
================
Comment at: llvm/lib/Object/GOFFObjectFile.cpp:337
+ }
+ llvm_unreachable("unable to get symbol section");
+ return section_iterator(SectionRef(Sec, this));
----------------
llvm_unreachable does not need a return
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89071/new/
https://reviews.llvm.org/D89071
More information about the llvm-commits
mailing list