[PATCH] D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 01:12:36 PST 2020


jhenderson added inline comments.


================
Comment at: llvm/lib/Object/GOFFObjectFile.cpp:46
+  if ((Object.getBufferSize() % GOFF::RecordLength) != 0) {
+    Err = createStringError(object_error::unexpected_eof, "Unexpected EOF");
+    return;
----------------
Be more verbose with your error messages, so that they provide more useful context. See https://llvm.org/docs/CodingStandards.html#error-and-warning-messages for full details.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89071/new/

https://reviews.llvm.org/D89071



More information about the llvm-commits mailing list