[PATCH] D91681: [lld][WebAssembly] Convert more tests to asm format. NFC.
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 18 14:08:03 PST 2020
sbc100 added a comment.
In D91681#2403863 <https://reviews.llvm.org/D91681#2403863>, @dschuff wrote:
> This conversion LGTM.
> It occurred to me that I don't know if we have tests that actually cover the conversion that we're removing here, namely LLVM IR -> assembly. e.g. after a really quick search I didn't see an ll test testing `extern_weak` globals in llvm/test/CodeGen/WebAssembly/ or llvm/test/MC/WebAssembly/. Did I just miss it?
Good question. I do normally check when I do these conversions but maybe I forgot this time. I will double check before I land.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91681/new/
https://reviews.llvm.org/D91681
More information about the llvm-commits
mailing list