[PATCH] D91681: [lld][WebAssembly] Convert more tests to asm format. NFC.

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 14:00:23 PST 2020


dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

This conversion LGTM.
It occurred to me that I don't know if we have tests that actually cover the conversion that we're removing here, namely LLVM IR -> assembly. e.g. after a really quick search I didn't see an ll test testing `extern_weak` globals in llvm/test/CodeGen/WebAssembly/ or llvm/test/MC/WebAssembly/. Did I just miss it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91681/new/

https://reviews.llvm.org/D91681



More information about the llvm-commits mailing list