[PATCH] D91058: [DebugInfo] Refactor code for emitting DWARF expressions for FP constants

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:234-236
+    addStackValue();
     if (Offset == 0 && Size <= 64)
       break;
----------------
This looks like a change in behavior - is it? Should it be tested?


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:247
+  // FIXME: Add support for `long double`.
+  if (NumBytes <= 8 /*double*/)
+    addUnsignedConstant(API, AP);
----------------
This looks like a change in behavior (now other <= 8 floating point sizes can be emitted - is it just that other such sizes are impossible/never come up? In which case maybe an assertion would be suitable?) & might possibly benefit from testing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91058/new/

https://reviews.llvm.org/D91058