[PATCH] D89180: [CSKY 2/n] Add basic tablegen infra for CSKY

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added inline comments.


================
Comment at: llvm/lib/Target/CSKY/CMakeLists.txt:1
+set(LLVM_TARGET_DEFINITIONS CSKY.td)
+
----------------
LLVM recently deprecated LLVMBuild, some of the functionalities were migrated to CMake. For example, LibraryGroup is replaced by `add_llvm_component_group` CMake function. You can take a look at how other targets did the migration


================
Comment at: llvm/lib/Target/CSKY/CSKYInstrFormats.td:13
+
+def AddrModeNone : AddrMode<0>;
+def AddrMode32B : AddrMode<1>;
----------------
Mind to briefly describe each addressing mode here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89180/new/

https://reviews.llvm.org/D89180